Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teraslice] Rename isRestartable to is isRelocatable #3761

Merged
merged 3 commits into from
Sep 19, 2024
Merged

[teraslice] Rename isRestartable to is isRelocatable #3761

merged 3 commits into from
Sep 19, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Sep 18, 2024

This PR makes the following changes:

Important Changes

  • Renames the isRestartable() function in the core slicer to isRelocatable() for better clarity on what this function is meant to return

@sotojn sotojn self-assigned this Sep 18, 2024
@sotojn
Copy link
Contributor Author

sotojn commented Sep 19, 2024 •
edited
Loading

I have validated the isRelocatable() functionality locally and it works as intended. Meaning If I delete a ex pod, it will come back on and continue if isRelocatable() returns true

@godber godber merged commit 0066cb3 into master Sep 19, 2024
67 checks passed
@godber godber deleted the rename-isRestartable-to-isRelocatable branch September 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@busma13 busma13 Awaiting requested review from busma13

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sotojn @godber